Update client address to be consistent with server address #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
client-address
branch
from
fb5cba6
to
bb4247b
Compare
lmolkova
reviewed
Sep 6, 2023
lmolkova
approved these changes
Sep 6, 2023
AlexanderWert
approved these changes
Sep 6, 2023
3 tasks
arminru
approved these changes
Sep 12, 2023
@Oberon00 I added "Closes #290" again in the description before merging and it seems to have worked: #290 (comment) |
|
Nice! For some reason it is not linked in the right sidebar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #251
Closes #290
Changes
Updates
client.addressto allow domain names for consistency withserver.address.This is consistent with the ECS definition of
client.address.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.