-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add session.previous_id #348
Add session.previous_id #348
Conversation
I think I get the idea of this proposal. But I think it would help if we had mobile- or client-specific semantic conventions that would describe how these attributes are intended to be used. I think it's clear for But, what about I think documenting this reasoning as mobile semantic conventions would be great! |
Yeah, I linked to the tracer in android to demonstrate, but yeah, the idea is to send a session change event. I can add some text in this same file to give more of an explanation of intent. Is this the right place for that, or, because it's behavioral does it belong in the spec repo? |
I think a new area of semantic conventions under With #197 the definition of the session attributes would go into the registry anyways and the mobile semantic conventions would just reference it. |
34bca22
to
08dcc03
Compare
8f485a5
to
e0f9096
Compare
@open-telemetry/semconv-mobile-approvers Can we get more reviews on this one please? |
1676bde
to
0fbb0ed
Compare
Hi @open-telemetry/specs-semconv-maintainers -- we have 4 approvals on this. Any reason to hold this up? 🙏🏻 |
Changes
Introduces a convention to represent the previous session id for client instrumentation. This can be used by telemetry backends to create links from the old/expired session to the new one.
Existing art exists in Android via the SessionIdChangeTracer.
Merge requirement checklist