-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark HTTP semantic conventions as stable #377
Conversation
some limitations we have in the md generator (and can address separately):
|
@lmolkova WDYT about rendering |
They seem to be rendered by default - https://github.com/open-telemetry/build-tools/blob/370e8f443612b312d9d30679f4cd513152fdab1b/semantic-conventions/src/opentelemetry/semconv/main.py#L210 We just never use them in markdown, so they don't appear. If we did, they'd appear as |
425242a
to
3dcfc9f
Compare
@lmolkova can you expand this PR to also update the stability of the http spans page and relevant metrics sections, so that it will be the one PR that we merge related to marking things stable? thx |
3d22fa2
to
320257e
Compare
I have been asked to review this PR, I can (only) confirm that as far as I know, there are no blockers left for stability so probably this is good to go. But I haven't been following the spec/semconv work closely enough recently to add a formal review here. |
Fixes #82
Merge requirement checklist
schema-next.yaml