BREAKING: Use seconds as default duration for FaaS duration histograms #384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #382
Changes
General guidelines for metric instrumentation units require that for measuring durations, seconds should be used:
This PR brings the FaaS metrics
faas.invoke_duration
,faas.init_duration
, andfaas.cpu.usage
in line with this requirement.As I couldn't find a place where those metrics are currently implemented or used, this change is proposed without recourse to any compatibility mechanism.
Merge requirement checklist