-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding messaging.rabbitmq.message.delivery_tag
to the list of RabbitMQ specific tags
#433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stebet please do not modify the markdown tables manually!
Instead, please add the new attribute in the corresponding model yaml file:
- id: messaging.rabbitmq |
Then, run make table-generation
to generate the markdown table automatically.
Awesome. Missed this step when I was reading over the docs. Will fix :) |
7d1afad
to
81c1276
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on #433 (comment)
@stebet Could you take a stab at #433 (comment)? Then I think this would be ready to be merged. |
Will do |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Hi @stebet ! We changed how the CHANGELOG.md is managed. Please take a look at https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#adding-a-changelog-entry to see what needs to be done. Sorry for the disruption. |
a8dc498
to
db47485
Compare
@stebet I took a liberty to update your PR to address comments, I hope you don't mind :) |
Also, I moved delivery_tag to message namespace, so it's |
Adding `messaging.rabbitmq.delivery_tag`
e498be3
to
860bfa3
Compare
@open-telemetry/semconv-messaging-approvers could you please take another look? |
messaging.rabbitmq.delivery_tag
to the list of RabbitMQ specific tagsmessaging.rabbitmq.message.delivery_tag
to the list of RabbitMQ specific tags
Thanks! I've been super busy with other things, so thank you. |
Changes
As requested by @lmolkova here, I'm adding a new RabbitMQ specific attribute:
messaging.rabbitmq.delivery_tag
. This tag and it's purpose is explained here: https://www.rabbitmq.com/confirms.html#consumer-acks-delivery-tagsMerge requirement checklist