Clarify producer span relationships and add a messaging example for a batch publishing scenario #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyohannes
force-pushed
the
dev/johannestax/messaging-batch-send-example
branch
from
db9050b
to
58a0703
Compare
joaopgrassi
previously approved these changes
Nov 14, 2023
AlexanderWert
approved these changes
Nov 14, 2023
lmolkova
reviewed
Nov 14, 2023
pyohannes
changed the title
alevenberg
reviewed
Dec 4, 2023
3 tasks
pyohannes
force-pushed
the
dev/johannestax/messaging-batch-send-example
branch
from
cb972e8
to
b3c66b8
Compare
hongalex
approved these changes
Jan 18, 2024
joaopgrassi
approved these changes
Jan 18, 2024
lmolkova
approved these changes
Jan 25, 2024
pyohannes
force-pushed
the
dev/johannestax/messaging-batch-send-example
branch
from
68a87a5
to
b466532
Compare
|
@pyohannes I think we should be good to merge this right? Can you please move the changelog changes to the new file-based one? |
pyohannes
force-pushed
the
dev/johannestax/messaging-batch-send-example
branch
from
b466532
to
8e8e83c
Compare
Done. This should be good to merge. |
|
Can we close the discussions, or you are still waiting for resolution on those? Merge is blocked by them now. |
ChrsMark
pushed a commit
to ChrsMark/semantic-conventions
that referenced
this pull request
Feb 21, 2024
… batch publishing scenario (open-telemetry#509)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-specification#1466
Changes
Based on recent changes from #284, this adds a messaging example illustrating a batch-publishing scenario involving "Publish" and "Create" spans.
Merge requirement checklist