-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temp fix for separation of resource and semantic attributes #524
Temp fix for separation of resource and semantic attributes #524
Conversation
…istry Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me.
Do we have additional information of where it was spotted and any additional background?
Also would that worth it to somehow document the valid type
s? Maybe in the registry's README?
On more details see the slack channel #otel-semantic-conventions-wg . This is just a temporary fix, but we need a cleaner solution long term. |
…emetry#524) Signed-off-by: Alexander Wert <alexander.wert@elastic.co> Co-authored-by: Josh Suereth <joshuasuereth@google.com> (cherry picked from commit 2817a7f)
…emetry#524) Signed-off-by: Alexander Wert <alexander.wert@elastic.co> Co-authored-by: Josh Suereth <joshuasuereth@google.com>
Fixes broken code generation that assumes that resource attributes are strictly separated from semantic attributes.
Merge requirement checklist
CHANGELOG.md updated for non-trivial changes.schema-next.yaml updated with changes to existing conventions.