Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp fix for separation of resource and semantic attributes #524

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

AlexanderWert
Copy link
Member

Fixes broken code generation that assumes that resource attributes are strictly separated from semantic attributes.

Merge requirement checklist

…istry

Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
@AlexanderWert AlexanderWert requested review from a team November 15, 2023 08:09
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.
Do we have additional information of where it was spotted and any additional background?
Also would that worth it to somehow document the valid types? Maybe in the registry's README?

@AlexanderWert
Copy link
Member Author

Do we have additional information of where it was spotted and any additional background?
Also would that worth it to somehow document the valid types? Maybe in the registry's README

On more details see the slack channel #otel-semantic-conventions-wg .

This is just a temporary fix, but we need a cleaner solution long term.

@jsuereth jsuereth merged commit 2817a7f into open-telemetry:main Nov 16, 2023
9 checks passed
arminru pushed a commit to dynatrace-oss-contrib/semantic-conventions that referenced this pull request Nov 17, 2023
…emetry#524)

Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
Co-authored-by: Josh Suereth <joshuasuereth@google.com>

(cherry picked from commit 2817a7f)
arminru added a commit that referenced this pull request Nov 17, 2023
… attributes (#524) (#537)

Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
pyohannes pushed a commit to pyohannes/semantic-conventions that referenced this pull request Jan 17, 2024
…emetry#524)

Signed-off-by: Alexander Wert <alexander.wert@elastic.co>
Co-authored-by: Josh Suereth <joshuasuereth@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants