move event attributes to the registry #543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Luna <39376769+mlunadia@users.noreply.github.com>
68 tasks
joaopgrassi
requested changes
Nov 20, 2023
docs/general/events.md
Outdated
|
|
||
| **[1]:** Events across different domains may have same `event.name`, yet be unrelated events. | ||
|
|
There was a problem hiding this comment.
Please render the table with full (check other examples) so we don't loose the enum table values
There was a problem hiding this comment.
as event.domain has been removed it looks like we don't need the full render anymore
trisch-me
reviewed
Nov 21, 2023
| @@ -0,0 +1,25 @@ | |||
| <!--- Hugo front matter used to generate the website version of this page: | |||
| linkTitle: Events | |||
There was a problem hiding this comment.
Should it be events or event?
6 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
ChrsMark
approved these changes
Jan 26, 2024
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves event attributes to the registry. It is part of #407