Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process.runtime.jvm.cpu.time metric #55

Merged
merged 6 commits into from
Jun 14, 2023

Conversation

trask
Copy link
Member

@trask trask commented May 26, 2023

Fixes open-telemetry/opentelemetry-specification#3490

Adds process.runtime.jvm.cpu.time metric.

@trask trask marked this pull request as ready for review May 26, 2023 00:03
@trask trask requested review from a team May 26, 2023 00:03
Copy link

@donbourne donbourne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trask trask mentioned this pull request Jun 1, 2023
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@trask
Copy link
Member Author

trask commented Jun 7, 2023

@open-telemetry/specs-semconv-maintainers do we need more approvals or is this good to merge? thx

@trask
Copy link
Member Author

trask commented Jun 7, 2023

I will fix broken link in this PR (similar issue as #96)

@reyang reyang merged commit 8f9fbdf into open-telemetry:main Jun 14, 2023
@trask trask deleted the add-jvm-cpu-time-metric branch June 14, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add process.runtime.jvm.cpu.time metric
9 participants