Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute for k8s pod annotations #573

Merged
merged 9 commits into from
Dec 15, 2023

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Dec 1, 2023

Changes

This adds support for pod's annotations to k8s.pod resource.
ref: #494 (comment)

Merge requirement checklist

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested review from a team December 1, 2023 10:40
@ChrsMark ChrsMark requested a review from a team December 1, 2023 10:41
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Member Author

ChrsMark commented Dec 6, 2023

@open-telemetry/specs-semconv-approvers @open-telemetry/specs-semconv-maintainers could you have a look please?

docs/resource/k8s.md Outdated Show resolved Hide resolved
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Member Author

Based on the discussion at #573 (comment) I have updated this PR to make the annotations attribute singular.
If we agree on this and the PR is approved I will create a separate issue to change k8s.pod.labels.* and container.labels.* as well.

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark self-assigned this Dec 12, 2023
Copy link
Contributor

@mlunadia mlunadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexanderWert AlexanderWert merged commit 73550a3 into open-telemetry:main Dec 15, 2023
9 checks passed
pyohannes pushed a commit to pyohannes/semantic-conventions that referenced this pull request Jan 17, 2024
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Alexander Wert <AlexanderWert@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants