Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depluralize labels for pod and container resources #625

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jan 3, 2024

Fixes #606

Changes

This PR de-pluralizes the container.labels.<key> and k8s.pod.labels.<key> attributes in order to ensure the consistency with other attributes of this "pattern":

  • http.response.header.<key>
  • k8s.pod.annotation.<key>

Merge requirement checklist

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested review from a team January 3, 2024 08:34
@ChrsMark ChrsMark requested a review from a team January 3, 2024 08:39
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark self-assigned this Jan 9, 2024
@joaopgrassi joaopgrassi merged commit 73b488a into open-telemetry:main Jan 9, 2024
9 checks passed
pyohannes pushed a commit to pyohannes/semantic-conventions that referenced this pull request Jan 17, 2024
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Joao Grassi <joao.grassi@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make container.labels and k8s.pod.labels singular
9 participants