-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database: clarify network attributes usage on common semconv #768
Conversation
4eb5f38
to
de4219e
Compare
do you think this is "because the instrumentation can", or because there is something about these databases that makes us include what I'm trying to understand is what's the criteria for including (or excluding) |
8d9535a
to
d941857
Compare
I can identify one good criteria - self-hosting (or hosting model where users configure/scale individual nodes). As a user who hosts cassandra, redis, elastic, etc clusters, I'm much more interested in which specific node this operation was performed on as it helps me detect issues with that specific node/my own infra, detect sharding/replication misconfiguration, etc. If I use fully managed DB (DBaaS), specific node information is probably missing (even if I have an IP address, it's probably a public one from load balancer or NAT) and not actionable. Basic sharding/replication is handled by my vendor to a big extent and not visible to my application. Update: mongoDB also supports self-hosted mode and might also be a candidate to have |
Update: based on the DB WG discussion on 3/8 the consensus is to keep |
dc3fd67
to
e45298a
Compare
e45298a
to
6c19a4a
Compare
30bba25
to
aff2193
Compare
Changes
Addresses DB portion of #690:
network.transport|type
attributes from general db semantic conventions.network.server.address|port
and keeps them on the cassandra, redis and elasticsearch extensionsBased on the findings from Java instrumentation libraries, following instrumentations populate network attributes:
See #698 (comment) for more details.
Merge requirement checklist
[chore]
schema-next.yaml updated with changes to existing conventions.