-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify metric attributes should be namespaced #786
Merged
arminru
merged 15 commits into
open-telemetry:main
from
dynatrace-oss-contrib:clarify-metric-namespace
Mar 8, 2024
Merged
Clarify metric attributes should be namespaced #786
arminru
merged 15 commits into
open-telemetry:main
from
dynatrace-oss-contrib:clarify-metric-namespace
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
changed the title
[core] Clarify metric attribute must be namespaced
[chore] Clarify metric attribute must be namespaced
Feb 29, 2024
2 tasks
arminru
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think this would still be worth an entry in the changelog to make others aware.
trask
approved these changes
Feb 29, 2024
jack-berg
reviewed
Feb 29, 2024
lmolkova
reviewed
Mar 1, 2024
joaopgrassi
changed the title
[chore] Clarify metric attribute must be namespaced
Clarify metric attribute must be namespaced
Mar 1, 2024
joaopgrassi
changed the title
Clarify metric attribute must be namespaced
Clarify metric attributes must be namespaced
Mar 1, 2024
joaopgrassi
changed the title
Clarify metric attributes must be namespaced
Clarify metric attributes should be namespaced
Mar 1, 2024
ChrsMark
reviewed
Mar 4, 2024
ChrsMark
approved these changes
Mar 4, 2024
lmolkova
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment on must vs should, but looks great otherwise
trask
reviewed
Mar 6, 2024
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
ChrsMark
approved these changes
Mar 7, 2024
pyohannes
approved these changes
Mar 7, 2024
Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
arminru
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394
Changes
Adds a section on the general metric guidelines about attributes. Specifically, calling out the TC decision about metric attributes being required to be namespaced.
Merge requirement checklist
[chore]