Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Rename messaging.client_id to messaging.client.id #948

Merged
merged 8 commits into from
May 3, 2024

Conversation

pyohannes
Copy link
Contributor

Fixes #935

Changes

This technically allows additional client specific attributes to be added to a messaging.client.* namespace.

Merge requirement checklist

@pyohannes pyohannes requested review from a team April 23, 2024 12:17
@pyohannes pyohannes force-pushed the messaging-client-id branch from 599ab69 to e91189e Compare May 3, 2024 13:12
@lmolkova lmolkova merged commit 4204c02 into open-telemetry:main May 3, 2024
11 of 12 checks passed
drewby pushed a commit to drewby/otel-semantic-conventions that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Rename messaging.client_id to messaging.client.id
5 participants