feat(env): support shards mode for game environment#21
Merged
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| for p in children: | ||
| try: | ||
| p.terminate() | ||
| except Exception: |
| except Exception: | ||
| try: | ||
| p.kill() | ||
| except Exception: |
lwaekfjlk
changed the title
Collaborator
Author
|
@zhusq20 This PR is designed for supporting shards number setting for game environment engine. Currently, for GRPO/PPO, the server would receive multiple requests in a batch. However, the server can only sequentially run those requests one by one. Therefore, shareds number supports the servers to have one worker on each port and have multiple ports open to recieve the requests and handle them in parallel. This is important for game environment because it takes time for theenvironment to do "reset" and "step" and we need to handle them in parallel. |
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
….com/open-tinker/OpenTinker into feature/optimize-alfworld-simplified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
📑 Description
✅ Checks
type/descript(e.g.feature/add-llm-agents)ℹ Additional Information