Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AnimalSniffer with Expediter for Android compat checks #220

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Replace AnimalSniffer with Expediter for Android compat checks #220

wants to merge 10 commits into from

Conversation

ogolberg
Copy link
Member

@ogolberg ogolberg commented Mar 10, 2024 •
edited
Loading

extensions-lite has some java.time converters which are not compatible with Android API < 26; extensions depends on extensions-lite and fails validation

@ogolberg ogolberg requested a review from andrewparmet March 10, 2024 15:37
@ogolberg ogolberg marked this pull request as draft March 11, 2024 18:23
@ogolberg ogolberg marked this pull request as ready for review March 25, 2024 16:38
@andrewparmet
Copy link
Collaborator

Do we still need gummybears at all?

@ogolberg
Copy link
Member Author

we don't - expediter just pulls in gummy bears internally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewparmet andrewparmet Awaiting requested review from andrewparmet

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogolberg @andrewparmet