-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of OSPFv2 OTG Model #384
Conversation
modified: device/dhcp/clients/v6/dhcpv6client.yaml modified: device/dhcp/common/dhcpv6options.yaml deleted: device/ospf/ospf.yaml deleted: device/ospf/ospfv2/interface/auth.yaml deleted: device/ospf/ospfv2/interface/interface.yaml deleted: device/ospf/ospfv2/interface/linkprotection.yaml deleted: device/ospf/ospfv2/router.yaml deleted: device/ospf/ospfv2/routerange/v4routerange.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review comments addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review comments closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One minor comment related to possible easier access of network_lsa neighbor router_ids array by test writer from ospfv2 state information.
Redocly Link: https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/open-traffic-generator/models/ospfv2/artifacts/openapi.yaml&nocors
OTG-PORT-1-OSPFv2 <-----------------------> DUT <-------------------------> OTG-PORT-2-OSPFv2