fix: revert eslint-plugin-json upgrade from v4 to v3 for eslint v8 comp #317
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpatibility Revert "fix(deps): update dependency eslint-plugin-json to v4" This reverts commit 5c3ee8b.
|
I am no longer seeing this error in manual testing, I think the issue is both packages in Schumacher need to be updated in sync. https://github.com/turo/web-schumacher-app/actions/runs/10917224321/job/30301410817 shows https://github.com/turo/web-schumacher-app/actions/runs/10917221063/job/30301768518 shows Both versions need to be updated at the same time to resolve this issue, it seems. Opening a manual PR for this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/azeemba/eslint-plugin-json:
If you are using eslint v9 or newer, use eslint-plugin-json v4 or newer.The "legacy" package was added in v4, but v4 only supports flat configs.