Matplotlib (and *-osx-dynamic tests) #51
Conversation
| COMMAND ${env} "${z_vcpkg_python_func_python}" -m gpep517 build-wheel --wheel-dir "${z_vcpkg_wheeldir}" --output-fd 1 ${build_ops} | ||
| COMMAND ${env} "${PYTHON3}" -m gpep517 build-wheel --wheel-dir "${z_vcpkg_wheeldir}" --output-fd 1 ${build_ops} |
There was a problem hiding this comment.
@Neumann-A what was your intent with z_vcpkg_python_func_python? Should this be the system python or something provided through vcpkg?
In the current state of this repository, it happens to be system python. In this case I think we'll need to acquire build dependencies (e.g. gpep517) similar to the py-meson approach above
https://github.com/open-vcpkg/python-registry/pull/51/files#diff-84817e4d8adab62c915c43e6a931b961f018d05eca77fc90b42fc62d032e8298R27
There was a problem hiding this comment.
The idea was to have a single place which handles which python gets used instead of having to change all vcpkg_execute_required_process calls
There was a problem hiding this comment.
where would this ideally be defined? in vcpkg-python-scripts/vcpkg-port-config.cmake ?
There was a problem hiding this comment.
I think it doesn't matter if the port-config or the scripts defined them. Thy will be in close proximity any way.
There was a problem hiding this comment.
PYTHON3is set byvcpkg-tool-meson/vcpkg-port-config.cmake- we need a python with build deps installed (e.g.
gpep517) - if we use
x_vcpkg_get_python_packagesto acquire missing packages, we need to replacePYTHON3with a python from the venv with the packages installed - build deps are known by the consuming port (
py-matplotlib) in this case, but I don't see how this could replacePYTHON3early enough
Options:
a) Use python from a host vcpkg port and specify build deps in vcpkg.json
b) Make it possible to inject build deps into vcpkg-python-scripts and create a venv in there
No description provided.