Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to deleted file in ms-python.python build script #766

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

JNuss71
Copy link
Contributor

@JNuss71 JNuss71 commented Jun 26, 2024

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

This PR removes reference to the deleted install_debugpy.py file in the build script for the ms-python.python extension which was causing build failure. The file was deleted in microsoft/vscode-python#23211 since debugpy was removed and the build script in the extension's repo was updated to remove the install_debugpy.py step.

@JNuss71 JNuss71 changed the title Remove reference to deleted file in python build script Remove reference to deleted file in ms-python.python build script Jun 27, 2024
Copy link
Collaborator

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there @JNuss71 👋,
thanks a lot for the contribution, it looks like the build is passing and having built it locally it seems to function as expected.

@filiptronicek filiptronicek merged commit be7c26e into open-vsx:master Jun 28, 2024
1 check failed
@JNuss71 JNuss71 deleted the fix/python_deps branch June 29, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants