Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually Update SilverStripe Extension #768

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Conversation

manuth
Copy link
Contributor

@manuth manuth commented Jul 6, 2024

  • I have read the note above about PRs contributing or fixing extensions
  • I have tried reaching out to the extension maintainers about publishing this extension to Open VSX (if not, please create an issue in the extension's repo using this template).
  • This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

As described in #767, the SilverStripe extension is unmaintained and hints the incorrect version number in its package.json file. Furthermore, the current .vsix file hosted on Open-VSX is broken and doesn't work properly - even causing other extensions to not getting loaded.

Therefore, changes made in this PR will:

  • Check out the (at time of writing) most recent commit
  • Set the (at time of writing) most recent version number in the package.json file
  • Apart from that publish it normally

Merging this PR will close #767

Copy link
Collaborator

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long time no see, @manuth!

Thanks for this, I've tried the produced package locally, and it seems to work as expected. I'm going to merge this, and after it gets published remove the extension from the list, because it does not seem like it will get any further updates.

@filiptronicek filiptronicek merged commit d333df1 into open-vsx:master Jul 10, 2024
1 check failed
@manuth
Copy link
Contributor Author

manuth commented Jul 11, 2024

Awesome to hear from you again! 😄
tysm for taking care!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SilverStripe Extension is Incomplete on Open-VSX
2 participants