This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
JavaScript sample testing process automation #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangyihui1
changed the title
yanbin7
changed the title
yanbin7
reviewed
Mar 7, 2019
src/start.py
Outdated
| headers = { | ||
| "Content-Type": "application/json" | ||
| } | ||
| task_id = do_request('https://10.239.44.83:8080/rest/v1/tasks', method="PUT", data=json.dumps(TASK), |
There was a problem hiding this comment.
this address is hard coded?
src/start.py
Outdated
| '--server', help='IATF server address.', required=True) | ||
| required_arguments.add_argument('--task', help='Task ID.', default=None) | ||
| opts = parser.parse_args() | ||
|
|
There was a problem hiding this comment.
remove unnecessary empty line
|
1: got task id automatically |
jianjunz
reviewed
Mar 7, 2019
| def do_request(url, method='GET', data=None, headers=None): | ||
| response = None | ||
| if method == 'GET': | ||
| response = requests.get(url, verify=False) |
There was a problem hiding this comment.
Setting verify=False here is a vulnerability.
|
|
||
|
|
||
| def start(id, server, verify): | ||
| cmd = ['python3.7', os.path.abspath(os.path.join(THIS_PATH, 'controller/controller.py')), '--server', server, |
There was a problem hiding this comment.
Run python from a python script doesn't make sense.
|
What we needed is get task id automatically which can be integrated to automation process conveniently. And it isn't make sense to set start.py here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.