Move extraEnvVars to Workload from ConfigMap #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I guess this fixes disabling the API when you disable the bundled Ollama chart. |
|
@0xThresh Done. I've made it a minor update like the previous change since this affects how environment variables are stored which could be a breaking change for some. Let me know if you would like it to just be a patch release instead. |
|
Thanks @saip92 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
extraEnvVarsvalue in the open-webui chart is inserted into a config map which is later mounted in the workload (deployment/stateful set) for its environment variables. But this does not support referencing secrets which are needed when using features like OIDC Authentication or PostgreSQL as the database.This PR removes the config map and moves the environment variables directly into the workload itself.
fixes #86
fixes #87