Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds translation on the location views #72

Open
andrebonon opened this issue Apr 2, 2024 · 1 comment · Fixed by YCloudYUSA/yusaopeny#180
Open

Adds translation on the location views #72

andrebonon opened this issue Apr 2, 2024 · 1 comment · Fixed by YCloudYUSA/yusaopeny#180

Comments

@andrebonon
Copy link
Contributor

andrebonon commented Apr 2, 2024 •
edited
Loading

Currently, the location views doesn't filter by the current language resulting on the views bringing duplicate results, for example a "Taggart Family Y" and its translation "Y de la famille Taggart".
Screenshot 2024-04-04 at 16 48 03

Proposed solution:

  • Views: Add a filter criteria "default_language", and filter by the default language in location views. It doesn't affect sites with only one language.
  • Makes the Branch Labels (/admin/config/content/location-filter-settings) translatable via config_translation (module).
  • Use the twig t() function so the "Filter by amenities" and the Search input placeholder can be translated
andrebonon added a commit to andrebonon/openy_map that referenced this issue Apr 3, 2024
@andrebonon
fix: [open-y-subprojects#72] Adds translation on the location views
ae73350
@andrebonon
Copy link
Contributor Author

#74

andrebonon added a commit to andrebonon/openy_map that referenced this issue Apr 4, 2024
@andrebonon
fix: [open-y-subprojects#72] Adds translation on the location views.
c2179e3
andrebonon added a commit to andrebonon/openy_map that referenced this issue May 3, 2024
@andrebonon
fix: [open-y-subprojects#72] Adds Language manager service as the Dat…
a081280 
…a Wrapper class now has it.
andrebonon added a commit to andrebonon/openy_map that referenced this issue May 3, 2024
@andrebonon
fix: [open-y-subprojects#72] Implements a hook_update to add the defa…
1bf8f30 
…ult language parameter to the location view.
andrebonon added a commit to andrebonon/openy_map that referenced this issue May 7, 2024
@andrebonon
fix: [open-y-subprojects#72] Implements a hook_update to add the defa…
9851425 
…ult language parameter to the location view.
andrebonon added a commit to andrebonon/openy_map that referenced this issue May 7, 2024
@andrebonon
fix: [open-y-subprojects#72] Implements a hook_update to add the defa…
b8ff341 
…ult language parameter to the location view.
podarok added a commit that referenced this issue May 8, 2024
@podarok
Merge pull request #74 from andrebonon/issue-72-adds-translation-on-l…
7ace9c8 
…ocation-views

fix: [#72] Adds translation on the location views
@podarok podarok mentioned this issue May 8, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Bump openy_map - add translation YCloudYUSA/yusaopeny
1 participant
@andrebonon