Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Pritoni model #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated Pritoni model #58

wants to merge 2 commits into from

Conversation

steveraysteveray
Copy link
Contributor

No description provided.

@steveraysteveray
Copy link
Contributor Author

@gtfierro, it's looking like the build process is not including the QUDT units graph, so there are many violations when units are referenced from the model files.

@gtfierro
Copy link
Contributor

Thanks for the heads up! I'll try to get to it early next week after I finish up some deadlines

@gtfierro
Copy link
Contributor

Hi @steveraysteveray I think I'm close to fixing this. I'm not getting any more QUDT errors on my machine, but now we'll test it on GItHub actions to see if it works here.

Are you double checking the models by downloading them from, for example: https://models.open223.info/examples/nist-bdg1-1.html#downloads ?

@steveraysteveray
Copy link
Contributor Author

Here's what I have so far:

  1. Download from open223 GitHub main - passes in TopBraid
  2. Download from open223 GitHub srr-update-pritoni - passes in TopBraid
  3. Download "compiled" from open223 (which is from main) - fails.
    1. Missing the import statement for ...model.all
  4. Download "original" from open223 (which is from main) - fails after inferencing.
    1. Explanation: the errors reflect pritoni before the updated the binary enumeration kinds. Maybe the enumeration kind files have been updated in open223, which is good. I haven't checked.

We have two separate branches on the open223 GitHub - my Pritoni file update and your fixing-compilation. It seems messy to create and push a third branch that builds on both of those. Would you consider just merging yours and then we can test my PR again?

@gtfierro
Copy link
Contributor

Just merged mine, so you are free to test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants