Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify the pairtools-dedup to select the best MAPQ alignment as output of deduplication #95

Closed
wants to merge 2 commits into from

Conversation

frankyan
Copy link

pairtools dedup outputs the first alignment of duplicates. The pull request is trying to output the best MAPQ alignment of duplicates instead of the first one. It can save some alignments when apply pairtools filter with MAPQ threshold after deduplication.

@golobor
Copy link
Member

golobor commented Mar 19, 2021

Dear @frankyan ,
apologies for the delayed response!
many thanks for your commit! It looks very clean and well-written.
Before we proceed though, I'd like to learn a bit more about the motivation behind this extra feature. Do you have any quantitative estimate on how many alignments this feature saves/improves? What scenarios does it address? I always assumed that duplicates are already quite similar to each other and thus would have similar MAPQs. The reason I'm asking is that extra features add to the maintenance cost and reduce transparency, so it's important to justify them.
Again, many thanks for your contribution, looking forward to hearing about your experience!
Anton.

@agalitsyna agalitsyna mentioned this pull request Apr 6, 2022
31 tasks
@golobor
Copy link
Member

golobor commented Apr 6, 2022

closing it for now for the lack of discussion; feel free to reopen!

@golobor golobor closed this Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants