Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMPathQuery matchSpecialisedNodes #448

Merged
merged 5 commits into from
Nov 23, 2022
Merged

Conversation

MattijsK
Copy link
Collaborator

@MattijsK MattijsK commented Nov 17, 2022

Adds matchSpecialisedNodes variable to RMPathQuery, which makes it possible to specify a path to return all specialised nodes as well.
For example: if an RM object of a specialisation of an archetype contains values of node id's 5.1 and 5.0.1 then creating an RMPathQuery with matchSpecialisedNodes = true and a query pointing to "id5", and then calling findList() (or find() but then only one result) would result in returning both the 5.1 and 5.0.1 objects.

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 71.34% // Head: 71.38% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (ef7833f) compared to base (5ecedb6).
Patch coverage: 96.77% of modified lines in pull request are covered.

❗ Current head ef7833f differs from pull request most recent head 636e019. Consider uploading reports for the commit 636e019 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #448      +/-   ##
============================================
+ Coverage     71.34%   71.38%   +0.03%     
- Complexity     6723     6735      +12     
============================================
  Files           657      657              
  Lines         22254    22276      +22     
  Branches       3573     3578       +5     
============================================
+ Hits          15877    15901      +24     
  Misses         4680     4680              
+ Partials       1697     1695       -2     
Impacted Files Coverage Δ
.../src/main/java/com/nedap/archie/aom/Archetype.java 90.67% <50.00%> (-0.71%) ⬇️
...main/java/com/nedap/archie/query/AOMPathQuery.java 85.18% <100.00%> (+0.11%) ⬆️
.../java/com/nedap/archie/rm/archetyped/Pathable.java 90.47% <100.00%> (+1.90%) ⬆️
.../main/java/com/nedap/archie/query/RMPathQuery.java 71.11% <100.00%> (+1.88%) ⬆️
...edap/archie/rmobjectvalidator/APathQueryCache.java 100.00% <100.00%> (ø)
...nedap/archie/rules/evaluation/AssertionsFixer.java 81.18% <100.00%> (ø)
.../nedap/archie/rules/evaluation/RuleEvaluation.java 90.36% <100.00%> (ø)
...main/java/com/nedap/archie/aom/utils/AOMUtils.java 77.38% <0.00%> (+1.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MattijsK MattijsK marked this pull request as ready for review November 23, 2022 10:28
@MattijsK MattijsK requested a review from J3173 November 23, 2022 10:28
@MattijsK MattijsK requested a review from J3173 November 23, 2022 12:32
@J3173 J3173 merged commit c755320 into master Nov 23, 2022
@J3173 J3173 deleted the rmpathquery_matchspecializednodes branch November 23, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants