Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Dutch translations marked as fuzzy #555

Merged
merged 9 commits into from
Dec 15, 2023
Merged

Review Dutch translations marked as fuzzy #555

merged 9 commits into from
Dec 15, 2023

Conversation

EBrader
Copy link
Collaborator

@EBrader EBrader commented Dec 13, 2023

resolves #551

Apart from fixing all fuzzy marked translations, also found 1 translation for which {0} was filled in twice, while the second should have been {1} in CTerminologyCode.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bd66b84) 71.68% compared to head (133207b) 71.71%.

Files Patch % Lines
.../nedap/archie/aom/primitives/CTerminologyCode.java 0.00% 1 Missing ⚠️
i18n/src/main/java/openehrArchie_nl.java 99.65% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #555      +/-   ##
============================================
+ Coverage     71.68%   71.71%   +0.03%     
  Complexity     6932     6932              
============================================
  Files           663      663              
  Lines         22649    22675      +26     
  Branches       3667     3667              
============================================
+ Hits          16235    16261      +26     
  Misses         4679     4679              
  Partials       1735     1735              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EBrader
Copy link
Collaborator Author

EBrader commented Dec 13, 2023

Codecov in this case invalid because it was readily not tested in old code.

i18n/po/i18n_nl.po Outdated Show resolved Hide resolved
i18n/po/i18n_nl.po Outdated Show resolved Hide resolved
i18n/po/i18n_nl.po Show resolved Hide resolved
@EBrader EBrader requested a review from MattijsK December 14, 2023 12:15
Copy link
Collaborator

@MattijsK MattijsK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also run i18n/compile.sh after you applied the changes?

i18n/po/i18n_nl.po Outdated Show resolved Hide resolved
i18n/po/i18n_nl.po Outdated Show resolved Hide resolved
i18n/po/i18n_nl.po Outdated Show resolved Hide resolved
i18n/po/i18n_nl.po Outdated Show resolved Hide resolved
EBrader and others added 6 commits December 14, 2023 13:38
Co-authored-by: Mattijs Kuhlmann <47526389+MattijsK@users.noreply.github.com>
Co-authored-by: Mattijs Kuhlmann <47526389+MattijsK@users.noreply.github.com>
# Conflicts:
#	i18n/po/i18n_en.po
#	i18n/po/i18n_nl.po
#	i18n/po/keys.pot
@EBrader EBrader requested a review from MattijsK December 14, 2023 12:47
Copy link
Collaborator

@MattijsK MattijsK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@EBrader EBrader merged commit 8c13bf9 into master Dec 15, 2023
2 checks passed
@EBrader EBrader deleted the 551 branch December 15, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Dutch translations marked as fuzzy
2 participants