Add term binding validation for IANA_media-type terminology #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #625 +/- ##
============================================
+ Coverage 71.94% 71.96% +0.01%
- Complexity 7066 7071 +5
============================================
Files 671 671
Lines 23034 23056 +22
Branches 3740 3745 +5
============================================
+ Hits 16572 16592 +20
Misses 4717 4717
- Partials 1745 1747 +2 ☔ View full report in Codecov by Sentry. |
J3173
requested changes
Sep 10, 2024
| @@ -19,8 +19,10 @@ | |||
|
|
|||
| public class OpenEHRTerminologyAccess implements TerminologyAccess { | |||
|
|
|||
| static volatile OpenEHRTerminologyAccess instance; | |||
| private static final Pattern openEHRTermIdPattern = Pattern.compile("http://openehr.org/id/(?<id>[0-9]+)"); | |||
| private static final Pattern IANATermIdPattern = Pattern.compile("https://www.w3.org/ns/iana/media-types/(?<type>[A-Za-z]+)/(?<subtype>[A-Za-z]+)#Resource"); | |||
There was a problem hiding this comment.
This regex is a bit too restrictive. Media types can also contain numbers and other special characters, see https://github.com/openEHR/archie/blob/master/openehr-terminology/src/main/resources/openEHR_RM/openehr_external_terminologies.xml#L525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remarks:
OpenEHRTerminologyAccessto retrieve media typeIANA_media-typesterm bindings for at codes./code_stringto terminology path instead of only for/defining_codepaths (e.g./media_typealso needs this)