Ungroup Sentry Error

that contains both of Environment Recovery Errors and Runner Recovery Errors.
openHPI · Aug 17, 2024 · 8bccbaf · 8bccbaf
1 parent cc9e20f
commit 8bccbaf
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/internal/environment/nomad_manager.go b/internal/environment/nomad_manager.go
@@ -181,13 +181,17 @@ func (m *NomadEnvironmentManager) KeepEnvironmentsSynced(ctx context.Context, sy
 	err := util.RetryConstantAttemptsWithContext(ctx, math.MaxInt, func() error {
 		// Load Environments
 		if err := m.load(ctx); err != nil {
-			log.WithContext(ctx).WithError(err).Warn("Loading Environments failed! Retrying...")
+			log.WithContext(ctx).WithError(err).
+				WithField(logging.SentryFingerprintFieldKey, []string{"{{ default }}", "environments"}).
+				Warn("Loading Environments failed! Retrying...")
 			return err
 		}
 
 		// Load Runners and keep them synchronized.
 		if err := synchronizeRunners(ctx); err != nil && ctx.Err() == nil {
-			log.WithContext(ctx).WithError(err).Warn("Loading and synchronizing Runners failed! Retrying...")
+			log.WithContext(ctx).WithError(err).
+				WithField(logging.SentryFingerprintFieldKey, []string{"{{ default }}", "runners"}).
+				Warn("Loading and synchronizing Runners failed! Retrying...")
 			return err
 		}
 

diff --git a/internal/nomad/api_querier.go b/internal/nomad/api_querier.go
@@ -142,7 +142,7 @@ func (nc *nomadAPIClient) Execute(ctx context.Context, runnerID string, cmd stri
 		// events of this error are caused by fsouza/go-dockerclient#1076. Because this error happens at the very end,
 		// it does not affect the functionality. Therefore, we don't propagate the error.
 		log.WithContext(span.Context()).WithError(err).
-			WithField(logging.SentryFingerprintFieldKey, "nomad-unexpected-eof").Warn("Unexpected EOF for Execute")
+			WithField(logging.SentryFingerprintFieldKey, []string{"nomad-unexpected-eof"}).Warn("Unexpected EOF for Execute")
 		return 0, nil
 	case strings.Contains(err.Error(), "Unknown allocation"):
 		return 1, ErrNomadUnknownAllocation

diff --git a/pkg/logging/sentry_hook.go b/pkg/logging/sentry_hook.go
@@ -54,8 +54,8 @@ func handleLogEntry(entry *logrus.Entry, hub *sentry.Hub, scope *sentry.Scope) (
 	if environmentID, ok := entry.Data[dto.KeyEnvironmentID].(string); ok {
 		scope.SetTag(dto.KeyEnvironmentID, environmentID)
 	}
-	if fingerprint, ok := entry.Data[SentryFingerprintFieldKey].(string); ok {
-		scope.SetFingerprint([]string{fingerprint})
+	if fingerprint, ok := entry.Data[SentryFingerprintFieldKey].([]string); ok {
+		scope.SetFingerprint(fingerprint)
 	}
 
 	event := client.EventFromMessage(entry.Message, sentry.Level(entry.Level.String()))