Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Context #426

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Merge Context #426

merged 2 commits into from
Aug 21, 2023

Conversation

mpass99
Copy link
Contributor

@mpass99 mpass99 commented Aug 21, 2023

Related to #406

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #426 (347b020) into main (306512b) will increase coverage by 0.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   75.89%   76.23%   +0.33%     
==========================================
  Files          38       39       +1     
  Lines        3535     3572      +37     
==========================================
+ Hits         2683     2723      +40     
+ Misses        685      683       -2     
+ Partials      167      166       -1     
Files Changed Coverage Δ
internal/runner/nomad_runner.go 82.55% <100.00%> (+0.17%) ⬆️
pkg/util/merge_context.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good (and seems to work fine 💪). There are just a few lint annotations, but otherwise I'd give it a try 👍

@mpass99 mpass99 force-pushed the fix/#406-merge-context branch from 40b167e to 30b9cc4 Compare August 21, 2023 20:33
@mpass99
Copy link
Contributor Author

mpass99 commented Aug 21, 2023

Oh yes, I forgot about it, thanks 👍

Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry, happy you were able to resolve them that quickly.

that has multiple contexts as parent and chooses the earliest deadline.
 to be done when either the runner is destroyed (case ignored before) or the request is interrupted.
@mpass99 mpass99 force-pushed the fix/#406-merge-context branch from 30b9cc4 to 347b020 Compare August 21, 2023 20:40
@mpass99 mpass99 merged commit c0a3fb1 into main Aug 21, 2023
@mpass99 mpass99 deleted the fix/#406-merge-context branch August 21, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants