Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebSocket JSON schema #456

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix WebSocket JSON schema #456

merged 1 commit into from
Sep 19, 2023

Conversation

mpass99
Copy link
Contributor

@mpass99 mpass99 commented Sep 19, 2023

by changing the required attribute to be an array as described in the official documentation.

by changing the required attribute to be an array as described in the official documentation.
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #456 (f276f6b) into main (3d25249) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
+ Coverage   75.45%   75.65%   +0.19%     
==========================================
  Files          39       39              
  Lines        3614     3614              
==========================================
+ Hits         2727     2734       +7     
+ Misses        713      708       -5     
+ Partials      174      172       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@MrSerth MrSerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works with JSONSchemer in CodeOcean as well.

mpass99 added a commit to openHPI/codeocean that referenced this pull request Sep 19, 2023
that included a wrong usage of the `required` attribute.

See #1914 and openHPI/poseidon#456.
@mpass99 mpass99 merged commit c83bdbf into main Sep 19, 2023
12 checks passed
@mpass99 mpass99 deleted the fix/json-schema branch September 19, 2023 09:15
MrSerth pushed a commit to openHPI/codeocean that referenced this pull request Sep 19, 2023
that included a wrong usage of the `required` attribute.

See #1914 and openHPI/poseidon#456.
MrSerth pushed a commit to openHPI/codeocean that referenced this pull request Sep 19, 2023
that included a wrong usage of the `required` attribute.

See #1914 and openHPI/poseidon#456.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants