Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Properly handle requests to list the file system #698

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

MrSerth
Copy link
Member

@MrSerth MrSerth commented Sep 26, 2024

AWS won't support listing the file system. However, since CodeOcean calls the method for each runner, this would yield an error every time. We want to avoid these errors and hence just handle this more gracefully.

@MrSerth MrSerth added the bug Something isn't working label Sep 26, 2024
@MrSerth MrSerth self-assigned this Sep 26, 2024

This comment was marked as off-topic.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.24%. Comparing base (1af6fcc) to head (cef4858).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/api/runners.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   76.30%   76.24%   -0.06%     
==========================================
  Files          43       43              
  Lines        3688     3688              
==========================================
- Hits         2814     2812       -2     
- Misses        638      640       +2     
  Partials      236      236              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dome-GER Dome-GER enabled auto-merge (rebase) October 15, 2024 18:39
@Dome-GER Dome-GER merged commit 75c7879 into main Oct 15, 2024
10 checks passed
@Dome-GER Dome-GER deleted the aws_file_system branch October 15, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants