Sync for Centers #717
Merged
Sync for Centers #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank-kgp
force-pushed
the
centersync
branch
8 times, most recently
from
7391819 to
5936df3
Compare
|
@therajanmaurya @puneetkohli521 Please review it.
|
therajanmaurya
requested changes
Jul 15, 2017
| @@ -12,5 +18,49 @@ | |||
| public static final String NAME = "Mifos"; | |||
|
|
|||
| //Always Increase the Version Number | |||
| public static final int VERSION = 2; | |||
| public static final int VERSION = 3; | |||
There was a problem hiding this comment.
@mayank-kgp you don't need to increase the DB version every time.
| public static final int VERSION = 3; | ||
|
|
||
| @Migration(version = MifosDatabase.VERSION, database = MifosDatabase.class) | ||
| public static class Migration1 extends AlterTableMigration<LoanAccount> { |
There was a problem hiding this comment.
@mayank-kgp don't make add migration classes here. Add new package directory database with name migrationversion2 and add all migration classes there.
|
@mayank-kgp I don't see any code that is syncing centre's groups and groups' clients. |
mayank-kgp
force-pushed
the
centersync
branch
5 times, most recently
from
7397da1 to
5ab8131
Compare
|
@therajanmaurya I have done the changes and updated the GIF. |
therajanmaurya
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.
#716 #711 (Grammatical mistake removed)