Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Profile Photo Unclickable #157

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Conversation

garvit984
Copy link
Collaborator

@garvit984 garvit984 commented Mar 13, 2020

Fixes #152

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@jawidMuhammadi
Copy link

Hey, @garvit984 why there are many commits in a single PR?

@@ -40,7 +40,7 @@
android:layout_width="65dp"
android:visibility="visible"
android:background="?selectableItemBackgroundBorderless"
android:clickable="true"
android:clickable="false"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we are making the profile picture unclickable?

@garvit984 garvit984 closed this Jun 6, 2020
# Conflicts:
#	app/src/main/kotlin/org/mifos/mobile/cn/ui/mifos/dashboard/DashboardFragment.kt
@garvit984 garvit984 reopened this Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile does not open
8 participants