Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Added Confirmation Dialog in Passcode Activity #95

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Fix: Added Confirmation Dialog in Passcode Activity #95

merged 1 commit into from
Dec 26, 2019

Conversation

rchtgpt
Copy link
Member

@rchtgpt rchtgpt commented Dec 23, 2019

Fixes #86

GIF:
ezgif com-video-to-gif (9)

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@rchtgpt
Copy link
Member Author

rchtgpt commented Dec 24, 2019 •
edited
Loading

@abhijitramesh @harshshinde07 @luckyman20 can you please review this ?

harshshinde07
harshshinde07 suggested changes Dec 24, 2019
View reviewed changes
Copy link

@harshshinde07 harshshinde07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the dialog message to the one you've added in the strings.xml file

luckyman20
luckyman20 approved these changes Dec 25, 2019
View reviewed changes
Copy link
Collaborator

@luckyman20 luckyman20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@luckyman20
Copy link
Collaborator

@abhijitramesh Can you please merge this?

@rchtgpt
Copy link
Member Author

rchtgpt commented Dec 25, 2019

Please change the dialog message to the one you've added in the strings.xml file

@harshshinde07 The GIF is not updated but I've put that string resource as the dialog message only 😃

@luckyman20 luckyman20 merged commit ca882ae into openMF:master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshshinde07 harshshinde07 harshshinde07 requested changes

@luckyman20 luckyman20 luckyman20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Add a confirmation dialog in forgot passcode
3 participants
@rchtgpt @luckyman20 @harshshinde07