Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Recent Transactions is opened without connection of internet App crashes #2442

Closed
kmanikanta335 opened this issue Nov 17, 2023 · 17 comments
Assignees

Comments

@kmanikanta335
Copy link
Contributor

Summary:

When user is offline if he opens Recent Transactions the App gets crashes instead it should show a Error layout of No Connection

Steps to reproduce:

1.open mifos mobile app
2. turn off internet
3. open recent transactions

Expected behaviour:

It should show error layout of No Connection

Observed behaviour:

App crashes

Screenshots:

issue1.mp4
@kmanikanta335
Copy link
Contributor Author

@PratyushSingh07 can i take this issue ?

@PratyushSingh07
Copy link
Collaborator

Sure , go ahead @kmanikanta335

@omjeem
Copy link

omjeem commented Nov 18, 2023

@PratyushSingh07 Please assign it to me !
till now i set up it locally in my Android studio
but for making a new registration it asked me for Account Number where do I get it??

@PratyushSingh07
Copy link
Collaborator

There is already someone assigned to this issue.
You don't have to create a new account @omjeem . Please go through the wiki page to get the demo credentials

@omjeem
Copy link

omjeem commented Nov 20, 2023

@PratyushSingh07 Thanks for the info! I'll check the wiki for demo credentials and continue working on the issue.

@ghost
Copy link

ghost commented Nov 25, 2023

@kmanikanta335 is the issue resolved..?

@kmanikanta335
Copy link
Contributor Author

kmanikanta335 commented Nov 25, 2023

@Thanush66 yes i am about to open a PR

@kmanikanta335
Copy link
Contributor Author

@PratyushSingh07 pls review it

@mayank0rajput
Copy link

is this issue resolved or still open?

@PratyushSingh07
Copy link
Collaborator

There is already an open PR linked to this issue @mayank0rajput

@antima123-bit
Copy link

can i take this issue sir please @PratyushSingh07

@PratyushSingh07
Copy link
Collaborator

can i take this issue sir please @PratyushSingh07

I'm afraid you cannot take this issue as we already have an open PR for this

@antima123-bit
Copy link

antima123-bit commented Dec 29, 2023 via email

kmanikanta335 added a commit to kmanikanta335/mifos-mobile that referenced this issue Jan 2, 2024
@PratyushSingh07
Copy link
Collaborator

hey @kmanikanta335 , I dont think we can replicate this issue any more. #2469 is what we get now. Can you just cross check this in your system and let us know.

kmanikanta335 added a commit to kmanikanta335/mifos-mobile that referenced this issue Jan 2, 2024
kmanikanta335 added a commit to kmanikanta335/mifos-mobile that referenced this issue Jan 2, 2024
@kmanikanta335
Copy link
Contributor Author

@PratyushSingh07 yes your are correct there is no required to replicate that issue #2469
Yes my system is showing proper error layout this issue as shown in the above video issue1.mp4

@PratyushSingh07
Copy link
Collaborator

so i can close this issue and its PR ,right ?

@kmanikanta335
Copy link
Contributor Author

@PratyushSingh07 ya sure no problem

@PratyushSingh07 PratyushSingh07 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants