fix #1009: New instance of home created only if language is changed #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miPlodder
requested changes
Feb 7, 2019
app/src/main/java/org/mifos/mobilebanking/ui/activities/SettingsActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobilebanking/ui/fragments/SettingsFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobilebanking/ui/activities/SettingsActivity.java
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobilebanking/ui/activities/SettingsActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobilebanking/ui/activities/SettingsActivity.java
Show resolved
Hide resolved
rahul-jha98
force-pushed
the
fix_SettingLaunchesNewActivity
branch
from
e0fd301 to
a641656
Compare
|
@rahul-jha98 Add GIF for this (every UI changes). Use DU recorder in your device for creating one. Rest looks good. 👍 |
|
When the user changes the language settings a new instance of Home Activity is created => When the user simply presses back with no change in language the Settings Activity simply closes with no wasteful Activity creation. |
|
@rahul-jha98 Good job 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1009
Please Add Screenshots If there are any UI changes.
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.