feat : login activity mvvm migration #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> modified Ui state class -> added unit tests for LoginViewModel
-> updated LoginViewModel unit tests -> added unit tests for functions related to login feature in UserAuthRepositoryTest
jawidMuhammadi
requested changes
Jul 9, 2023
app/src/main/java/org/mifos/mobile/repositories/UserAuthRepository.kt
Outdated
Show resolved
Hide resolved
-> created ClientRepository, its implementation and unit tests. -> removed Client related methods from UserAuthRepository, and its unit tests. -> injected ClientRepositoryImp to LoginViewModel through Hilt, and added its entry to repository module of DI
-> injected preferences helper dependency through hilt
…tivity-mvvm-migration # Conflicts: # app/src/main/java/org/mifos/mobile/injection/module/RepositoryModule.kt # app/src/main/java/org/mifos/mobile/repositories/ClientRepository.kt # app/src/main/java/org/mifos/mobile/repositories/ClientRepositoryImp.kt # app/src/main/java/org/mifos/mobile/repositories/UserAuthRepository.kt # app/src/main/java/org/mifos/mobile/repositories/UserAuthRepositoryImp.kt # app/src/test/java/org/mifos/mobile/repositories/ClientRepositoryImpTest.kt
|
Hey @jawidMuhammadi, do have a look at this whenever you find the bandwith. I've resolved the conflicts as well. 😃 |
…tivity-mvvm-migration # Conflicts: # app/src/main/java/org/mifos/mobile/injection/module/RepositoryModule.kt # app/src/main/java/org/mifos/mobile/repositories/UserAuthRepository.kt # app/src/main/java/org/mifos/mobile/repositories/UserAuthRepositoryImp.kt # app/src/test/java/org/mifos/mobile/repositories/UserAuthRepositoryImpTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOBILE-67
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with
./gradlew checkto make sure you didn't break anythingApply the
AndroidStyle.xmlstyle template to your code in Android Studio.If you have multiple commits please combine them into one commit by squashing them.