Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrated loan related presenter to mvvm #2209

Merged

Conversation

PratyushSingh07
Copy link
Collaborator

Jira ticket : https://mifosforge.jira.com/browse/MOBILE-98

This PR migrates the following fragments to MVVM :

  • LoanAccountsDetailFragment
  • LoanAccountTransactionFragment
  • LoanAccountWithdrawFragment
  • LoanApplicationViewFragment
  • LoanRepaymentScheduleFragment

All of the respective view model share a common repository i.e LoanRepository

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@PratyushSingh07 PratyushSingh07 marked this pull request as ready for review July 15, 2023 17:24
@PratyushSingh07 PratyushSingh07 marked this pull request as draft July 15, 2023 20:20
@PratyushSingh07 PratyushSingh07 marked this pull request as ready for review July 21, 2023 11:01
@PratyushSingh07
Copy link
Collaborator Author

@jawidMuhammadi review this whenever you get the time

@jawidMuhammadi jawidMuhammadi merged commit 9d93078 into openMF:mvvm_architecture Jul 22, 2023
3 checks passed
@PratyushSingh07 PratyushSingh07 deleted the loanAcc-detail-mvvm branch October 5, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants