-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-#2104-Unable-to-login-after-clicking-on-the-cancel-button #2232
fix-#2104-Unable-to-login-after-clicking-on-the-cancel-button #2232
Conversation
i think your commit message is wrong . You have solved another issue but you are referencing an entirely different one. |
acffaa7
to
b2d6166
Compare
Sorry for it. I have rectified the my mistake and done the appropriate changes. |
@PratyushSingh07 any update on this PR. Please do let me know if any changes are required |
) | ||
.createMaterialDialog() | ||
.show() | ||
TODO() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why TODO() ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because earlier the show dialogue box logic was written in this method, so I moved that logic to button click listener and may be in future we could write some appropriate functionality in this overwritten method therefore I mentioned TODO in it
also, I cannot merge your PRs @vyukti13 thats upto our mentor @jawidMuhammadi |
Hi @therajanmaurya as discussed , I have opened PR #2277 in place of this PR. We can hence close this down |
Fixes #2104
Issue was fixed. Now even after clicking CANCEL button used was able to login into app after giving correct pin