fix-#2104-Unable-to-login-after-clicking-on-the-cancel-button #2232
Conversation
|
i think your commit message is wrong . You have solved another issue but you are referencing an entirely different one. |
vyukti13
changed the title
vyukti13
force-pushed
the
fix-#2104-Unable-to-login-after-clicking-on-the-cancel-button
branch
from
acffaa7
to
b2d6166
Compare
|
Sorry for it. I have rectified the my mistake and done the appropriate changes. |
|
@PratyushSingh07 any update on this PR. Please do let me know if any changes are required |
| ) | ||
| .createMaterialDialog() | ||
| .show() | ||
| TODO() |
There was a problem hiding this comment.
Because earlier the show dialogue box logic was written in this method, so I moved that logic to button click listener and may be in future we could write some appropriate functionality in this overwritten method therefore I mentioned TODO in it
|
also, I cannot merge your PRs @vyukti13 thats upto our mentor @jawidMuhammadi |
|
Hi @therajanmaurya as discussed , I have opened PR #2277 in place of this PR. We can hence close this down |
Fixes #2104
Issue was fixed. Now even after clicking CANCEL button used was able to login into app after giving correct pin