Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts Presenter migration to mvvm #2254

Conversation

gururani-abhishek
Copy link
Contributor

Fixes MOBILE-106

Please Add Screenshots If there are any UI changes.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

-> migrated AccountsFragment and ClientAccountsFragment
…-fragment-migration-to-mvvm

# Conflicts:
#	app/src/main/java/org/mifos/mobile/injection/module/RepositoryModule.kt
@jawidMuhammadi
Copy link
Contributor

Hey @gururani-abhishek, what is the status of this PR, would you happen to need any help?

@gururani-abhishek
Copy link
Contributor Author

Greetings of the day Jawid, it is complete from my end 😀, @jawidMuhammadi

@gururani-abhishek gururani-abhishek marked this pull request as ready for review August 8, 2023 14:38
Copy link
Contributor

@jawidMuhammadi jawidMuhammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, LGTM! :)

@jawidMuhammadi jawidMuhammadi merged commit f4c390a into openMF:development Aug 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants