fixed dark mode splash screen. #2484
Conversation
-> so, i added one dark mode colors file in values. -> now any dark mode related work can be done there. -> also fixed splash screen dark mode issue.
- deleted the old change in values: -> deleted the colors(night). - implemented the theme of splash screen with the base theme. -so it can work according to mobile theme.
|
alright @KUSHAL-RAJ-PAREEK 3 things that I would like to point out :
I appreciate the enthusiasm, but it's crucial to uphold the essence of open source. Don't limit your contributions solely with GSoC in mind. Take the time to learn from fellow contributors, and, most importantly, avoid rushing the process. I hope you will not repeat this |
|
@PratyushSingh07 WhatsApp.Video.2024-01-15.at.13.12.06_8bcef29e.mp4 |
|
so, if i follow quidelines then i also cant able to make pr? |
|
guidelines file for pr in readme is not found. |
|
Why won't you be able to make a PR if you follow the guidelines? You have taken my points out of context. Also you are changing the system theme. Try changing the theme from inside of the app to see if it works |
Did you try checking contributing.md ?? |
|
i am saying that pr guidelines link is not working.
…On Mon, Jan 15, 2024 at 1:19 PM Pratyush Singh ***@***.***> wrote:
Why won't you be able to make a PR if you follow the guidelines? You have
taken my points out of context.
Also you are changing the system theme. Try changing the theme from inside
of the app to see if it works
—
Reply to this email directly, view it on GitHub
<#2484 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3SEYB5FTZRDBSMNJ53QT3LYOTNQZAVCNFSM6AAAAABB2Y44UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGQ4TMOJZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
ok i go it. thanks
…On Mon, Jan 15, 2024 at 1:21 PM Pratyush Singh ***@***.***> wrote:
guidelines file for pr in readme is not found.
Did you try checking contributing.md ??
—
Reply to this email directly, view it on GitHub
<#2484 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3SEYBY46LXWJI354HKJXOLYOTNZLAVCNFSM6AAAAABB2Y44UGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRGUYDEOJWGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
ya its not changing let me see. |
|
do you still plan to solve the issue in this PR or should I close it @KUSHAL-RAJ-PAREEK ? |
|
@PratyushSingh07 i will spend some more time on this issue. |
|
I am converting this PR to draft |
|
closing due to inactivity. Reopen the PR if you make any progress |
@PratyushSingh07
Fixes #2466
WhatsApp.Video.2024-01-12.at.21.33.23_95e115ea.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.