-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2656] - refactor : Registration Screen from XML to Compose #2631
Merged
therajanmaurya
merged 3 commits into
openMF:development
from
akashmeruva9:registration_compose
Jun 30, 2024
Merged
[2656] - refactor : Registration Screen from XML to Compose #2631
therajanmaurya
merged 3 commits into
openMF:development
from
akashmeruva9:registration_compose
Jun 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashmeruva9
changed the title
Registration compose
refactor : Registration Screen from XML to Compose
Jun 29, 2024
itsPronay
suggested changes
Jun 29, 2024
app/src/main/java/org/mifos/mobile/ui/registration/RegistrationComposeFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/registration/RegistrationComposeFragment.kt
Outdated
Show resolved
Hide resolved
itsPronay
reviewed
Jun 29, 2024
app/src/main/java/org/mifos/mobile/ui/registration/RegistrationScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/registration/RegistrationViewModel.kt
Outdated
Show resolved
Hide resolved
itsPronay
reviewed
Jun 29, 2024
app/src/main/java/org/mifos/mobile/ui/registration/RegistrationViewModel.kt
Outdated
Show resolved
Hide resolved
itsPronay
reviewed
Jun 29, 2024
app/src/main/java/org/mifos/mobile/ui/registration/RegistrationScreen.kt
Outdated
Show resolved
Hide resolved
akashmeruva9
force-pushed
the
registration_compose
branch
from
June 29, 2024 18:19
6a76b82
to
ba0d5fe
Compare
akashmeruva9
force-pushed
the
registration_compose
branch
from
June 29, 2024 18:33
ba0d5fe
to
f83742b
Compare
akashmeruva9
added a commit
to akashmeruva9/mifos-mobile
that referenced
this pull request
Jul 1, 2024
akashmeruva9
changed the title
refactor : Registration Screen from XML to Compose
[2656] - refactor : Registration Screen from XML to Compose
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2630
WhatsApp.Video.2024-06-29.at.19.50.27_5a034b1b.mp4
[x ] Apply the
AndroidStyle.xml
style template to your code in Android Studio.[ x] Run the unit tests with
./gradlew check
to make sure you didn't break anything[ x] If you have multiple commits please combine them into one commit by squashing them.