refactor: location module

app/build.gradle.kts

@@ -91,6 +91,7 @@ dependencies {
     implementation(projects.feature.thirdPartyTransfer)
     implementation(projects.feature.help)
     implementation(projects.feature.notification)
+    implementation(projects.feature.location)
 
 
     implementation("androidx.legacy:legacy-support-v4:1.0.0")
@@ -99,7 +100,7 @@ dependencies {
     implementation(libs.androidx.appcompat)
     implementation(libs.material)
     implementation(libs.androidx.preference)
-    implementation(libs.play.services.maps)
+
 
     // DBFlow
     implementation(libs.dbflow)
@@ -197,8 +198,6 @@ dependencies {
     debugApi(libs.androidx.compose.ui.tooling)
     api(libs.androidx.hilt.navigation.compose)
 
-    // google maps
-    implementation ("com.google.maps.android:maps-compose:4.4.1")
 
     //image cropper
     implementation("com.github.CanHub:Android-Image-Cropper:4.0.0")

app/src/main/java/org/mifos/mobile/ui/location/LocationsFragment.kt

@@ -6,7 +6,7 @@ import android.view.View
 import android.view.ViewGroup
 import androidx.fragment.app.Fragment
 import org.mifos.mobile.core.ui.component.mifosComposeView
-import org.mifos.mobile.core.ui.theme.MifosMobileTheme
+import org.mifos.mobile.feature.location.LocationsScreen
 
 class LocationsFragment : Fragment() {
 
@@ -16,9 +16,7 @@ class LocationsFragment : Fragment() {
         savedInstanceState: Bundle?
     ): View {
         return mifosComposeView(requireContext()) {
-            MifosMobileTheme {
-                LocationsScreen()
-            }
+            LocationsScreen()
         }
     }
 

app/src/main/res/layout/fragment_locations.xml

@@ -21,11 +21,5 @@
         android:layout_height="wrap_content"
         android:text="@string/mifos_location" />
 
-    <com.google.android.gms.maps.MapView
-        android:id="@+id/map"
-        android:layout_width="match_parent"
-        android:layout_height="@dimen/height_0dp"
-        android:layout_marginTop="@dimen/Mifos.DesignSystem.Spacing.CardInnerPaddingLarge"
-        android:layout_weight="1" />
 
 </LinearLayout>

feature/location/.gitignore

@@ -0,0 +1 @@
+/build

feature/location/build.gradle.kts

@@ -0,0 +1,17 @@
+plugins {
+    alias(libs.plugins.mifos.android.feature)
+    alias(libs.plugins.mifos.android.library.compose)
+}
+
+android {
+    namespace = "org.mifos.mobile.feature.location"
+}
+
+dependencies {
+    // google maps
+    implementation(libs.google.map.compose)
+
+    testImplementation(libs.junit)
+    androidTestImplementation(libs.androidx.test.ext.junit)
+    androidTestImplementation(libs.espresso.core)
+}

feature/location/proguard-rules.pro

@@ -0,0 +1,21 @@
+# Add project specific ProGuard rules here.
+# You can control the set of applied configuration files using the
+# proguardFiles setting in build.gradle.
+#
+# For more details, see
+#   http://developer.android.com/guide/developing/tools/proguard.html
+
+# If your project uses WebView with JS, uncomment the following
+# and specify the fully qualified class name to the JavaScript interface
+# class:
+#-keepclassmembers class fqcn.of.javascript.interface.for.webview {
+#   public *;
+#}
+
+# Uncomment this to preserve the line number information for
+# debugging stack traces.
+#-keepattributes SourceFile,LineNumberTable
+
+# If you keep the line number information, uncomment this to
+# hide the original source file name.
+#-renamesourcefileattribute SourceFile

feature/location/src/androidTest/java/org/mifos/mobile/feature/location/ExampleInstrumentedTest.kt

@@ -0,0 +1,24 @@
+package org.mifos.mobile.feature.location
+
+import androidx.test.platform.app.InstrumentationRegistry
+import androidx.test.ext.junit.runners.AndroidJUnit4
+
+import org.junit.Test
+import org.junit.runner.RunWith
+
+import org.junit.Assert.*
+
+/**
+ * Instrumented test, which will execute on an Android device.
+ *
+ * See [testing documentation](http://d.android.com/tools/testing).
+ */
+@RunWith(AndroidJUnit4::class)
+class ExampleInstrumentedTest {
+    @Test
+    fun useAppContext() {
+        // Context of the app under test.
+        val appContext = InstrumentationRegistry.getInstrumentation().targetContext
+        assertEquals("org.mifos.mobile.feature.location.test", appContext.packageName)
+    }
+}

feature/location/src/main/AndroidManifest.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
+
+</manifest>

app/src/main/java/org/mifos/mobile/ui/location/LocationScreen.kt → feature/location/src/main/java/org/mifos/mobile/feature/location/LocationScreen.kt

@@ -1,4 +1,4 @@
-package org.mifos.mobile.ui.location
+package org.mifos.mobile.feature.location
 
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.Spacer
@@ -14,15 +14,13 @@ import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import androidx.compose.ui.viewinterop.AndroidView
-import com.google.android.gms.maps.GoogleMap
 import com.google.android.gms.maps.MapView
 import com.google.android.gms.maps.model.CameraPosition
 import com.google.android.gms.maps.model.LatLng
 import com.google.maps.android.compose.GoogleMap
 import com.google.maps.android.compose.Marker
 import com.google.maps.android.compose.MarkerState
 import com.google.maps.android.compose.rememberCameraPositionState
-import org.mifos.mobile.R
 import org.mifos.mobile.core.ui.theme.MifosMobileTheme
 import kotlin.coroutines.coroutineContext
 

feature/location/src/main/res/values/strings.xml

@@ -0,0 +1,7 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <string name="mifos_initiative">Mifos Initiative</string>
+    <string name="mifos_location">Mifos Initiative , Seattle , Washington 98121</string>
+    <string name="map_marker_heading">Seattle</string>
+    <string name="map_marker_desc">Home to large tech industry</string>
+</resources>

feature/location/src/test/java/org/mifos/mobile/feature/location/ExampleUnitTest.kt

@@ -0,0 +1,17 @@
+package org.mifos.mobile.feature.location
+
+import org.junit.Test
+
+import org.junit.Assert.*
+
+/**
+ * Example local unit test, which will execute on the development machine (host).
+ *
+ * See [testing documentation](http://d.android.com/tools/testing).
+ */
+class ExampleUnitTest {
+    @Test
+    fun addition_isCorrect() {
+        assertEquals(4, 2 + 2)
+    }
+}

gradle/libs.versions.toml

@@ -52,6 +52,7 @@ playServicesCodeScanner = "16.1.0"
 googleAppCodeScanner = "17.2.0"
 cameraxVersion = "1.3.1"
 compose-material = "1.6.8"
+googleMaps = "4.4.1"
 
 [libraries]
 androidx-activity-ktx = { module = "androidx.activity:activity-ktx", version.ref = "activityVersion" }
@@ -112,6 +113,7 @@ androidx-camera-camera2 = { group = "androidx.camera", name = "camera-camera2",
 androidx-camera-lifecycle = { group = "androidx.camera", name = "camera-lifecycle", version.ref = "cameraxVersion"}
 androidx-camera-view = { group = "androidx.camera", name = "camera-view", version.ref = "cameraxVersion"}
 androidx-camera-core = { group = "androidx.camera", name = "camera-core", version.ref = "cameraxVersion" }
+google-map-compose = { group = "com.google.maps.android", name = "maps-compose", version.ref = "googleMaps" }
 
 # Dependencies of the included build-logic
 android-gradlePlugin = { group = "com.android.tools.build", name = "gradle", version.ref = "androidGradlePlugin" }

settings.gradle.kts

@@ -42,3 +42,4 @@ include(":feature:client_charge")
 include(":feature:third-party-transfer")
 include(":feature:help")
 include(":feature:notification")
+include(":feature:location")