Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Removed the onBackPressed Bug in TransferProcessFragment #724

Merged
merged 1 commit into from
Apr 12, 2018

Conversation

sridharjajoo
Copy link
Contributor

@sridharjajoo sridharjajoo commented Mar 13, 2018

Fixes #665
device-2018-03-13-144249

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@miPlodder
Copy link
Collaborator

miPlodder commented Mar 13, 2018

@sridharjajoo Please review Checkstyle errors from link below and update the PR.

https://travis-ci.org/openMF/mifos-mobile/builds/352745365#L2888

@sridharjajoo
Copy link
Contributor Author

@therajanmaurya @dilpreet96 Kindly review!

@@ -147,6 +149,7 @@ public void closeClicked() {
getActivity().getSupportFragmentManager().popBackStack();
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this blank line.

@@ -79,6 +80,7 @@ public static TransferProcessFragment newInstance(TransferPayload payload, Trans
return fragment;
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this blank line.

@therajanmaurya
Copy link
Member

@sridharjajoo Please follow commit guideline. you can find guideline doc in wiki.

@sridharjajoo sridharjajoo changed the title Removed the onBackPressed Bug in TransferProcessFragment fix: Removed the onBackPressed Bug in TransferProcessFragment Mar 17, 2018
@sridharjajoo
Copy link
Contributor Author

@therajanmaurya Thanks! Will take care of that in future.

@sridharjajoo
Copy link
Contributor Author

@therajanmaurya Done the changes!

@therajanmaurya
Copy link
Member

therajanmaurya commented Mar 17, 2018

@sridharjajoo your commit message supposed to be this
Fix: Removed the onBackPressed Bug in TransferProcessFragment

@sridharjajoo sridharjajoo changed the title fix: Removed the onBackPressed Bug in TransferProcessFragment Fix: Removed the onBackPressed Bug in TransferProcessFragment Mar 17, 2018
@sridharjajoo
Copy link
Contributor Author

sridharjajoo commented Mar 17, 2018

@therajanmaurya @dilpreet96 Kindly review this P.R.

@sridharjajoo
Copy link
Contributor Author

@therajanmaurya Kindly review!

@therajanmaurya therajanmaurya merged commit bf5e16d into openMF:development Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants