-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Removed the onBackPressed Bug in TransferProcessFragment #724
Conversation
@sridharjajoo Please review Checkstyle errors from link below and update the PR. https://travis-ci.org/openMF/mifos-mobile/builds/352745365#L2888 |
427a9bc
to
7e1512c
Compare
@therajanmaurya @dilpreet96 Kindly review! |
@@ -147,6 +149,7 @@ public void closeClicked() { | |||
getActivity().getSupportFragmentManager().popBackStack(); | |||
} | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this blank line.
@@ -79,6 +80,7 @@ public static TransferProcessFragment newInstance(TransferPayload payload, Trans | |||
return fragment; | |||
} | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this blank line.
@sridharjajoo Please follow commit guideline. you can find guideline doc in wiki. |
7e1512c
to
219a0bc
Compare
@therajanmaurya Thanks! Will take care of that in future. |
@therajanmaurya Done the changes! |
@sridharjajoo your commit message supposed to be this |
@therajanmaurya @dilpreet96 Kindly review this P.R. |
219a0bc
to
e5a0613
Compare
@therajanmaurya Kindly review! |
Fixes #665
Apply the
AndroidStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.