-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #747 : Added Checks for empty Edittexts and for validity of Url in Update Endpoints Setting #765
Conversation
@therajanmaurya @dilpreet96 @satyan @droidchef Please review this PR. |
app/src/main/res/values/strings.xml
Outdated
@@ -383,6 +383,8 @@ | |||
<string name="language">Language</string> | |||
<string name="choose_language">Choose your language</string> | |||
<string name="notification">Notifications</string> | |||
<string name="base_url">Base Url</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be Base URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luckyman20 I have used "Base Url" because the Title also shows "Base Url". It's better to have consistency in messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miPlodder I think you can change that too also because URL is a short form for Uniform Resource Locater & short forms should be written in caps only.
@miPlodder Another approach you can use that check all the things when You should also check whether it is a valid URL or not |
@luckyman20 I have made a check for validity of the URL. Moreover, when Moreover, it's good approach to give continuous feedback to user in forms where lesser number of fields are available. That's why I have used TextWatcher. |
Fix conflicts. |
…n Update Endpoints Setting
@therajanmaurya Please review this PR again. |
Fixes #747
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.