Feat: Add swahili language translation #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luckyman20
reviewed
Nov 25, 2018
There was a problem hiding this comment.
@letelete I see some of the strings aren't translated, any specific reason for that.
|
I've removed strings which, imho, shouldn't be translated like app name and location. Am I wrong with this? |
|
App name and location are fine but strings like Password, filter etc. should be translated. |
|
Oh, yeah, looks like I missed a couple of these. I'm going to translate them now. |
letelete
force-pushed
the
swahili-translation
branch
from
92dd00f to
4c7af6c
Compare
|
Updated! Should be fine already. |
luckyman20
reviewed
Nov 25, 2018
letelete
force-pushed
the
swahili-translation
branch
from
4c7af6c to
2fc05db
Compare
|
Is there anything else I should fix? |
letelete
force-pushed
the
swahili-translation
branch
from
2fc05db to
e3d8d39
Compare
|
@letelete Travis is failing, fix that. |
|
It's passing locally. Travis logs:
|
letelete
force-pushed
the
swahili-translation
branch
from
e3d8d39 to
5f4bf12
Compare
luckyman20
approved these changes
Nov 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #Issue_Number
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.