Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Search Bar Allignment Issue #977

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

shiv07tiwari
Copy link
Member

Fixes #976

Fixed this issue as per device width. (I saw it was fixed as well, but the solution didnt work for all devices.)

Please Add Screenshots If there are any UI changes.
image
Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@shiv07tiwari
Copy link
Member Author

@luckyman20 @ankurs287

@therajanmaurya
Copy link
Member

@shiv07tiwari Good Job, You are right #976 (comment). We don't need the filter option while searching. Please make the changes

  1. Hide filter option if the search option is visible.
  2. When the search option is visible and the user clicks the back button and close the keyboard and if there is no text in the search box then search box should be closed and show search and filter menu button.

Please make changes and let me know. I will review and merge.

@shiv07tiwari
Copy link
Member Author

Thanks @therajanmaurya
I talked to @luckyman20 about the comment, and we think the their might be a case while user is searching, but may still apply filters for better crisp results.
So, is this a considerable use-case, or should I remove the filter option completely as per your suggestion ?

@therajanmaurya
Copy link
Member

@shiv07tiwari Ohhh, I appreciate your thoughts and I am happy to say you and @luckyman20 are right about this. Sorry I missed this scenario.

Good Job. Let me review and merge.

@therajanmaurya therajanmaurya merged commit d2340c7 into openMF:development Jan 15, 2019
@shiv07tiwari
Copy link
Member Author

@therajanmaurya Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter icon is not aligned properly while using Search in Account
2 participants