Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Profile Pic edit btn from profile fragment #1158

Open
EGOR-IND opened this issue Jan 14, 2021 · 7 comments
Open

Remove Profile Pic edit btn from profile fragment #1158

EGOR-IND opened this issue Jan 14, 2021 · 7 comments

Comments

@EGOR-IND
Copy link
Contributor

Summary:

On the profile fragment there is a camera ImageView that is used to edit profile pic which should not be there and occur after user enters edit profile activity.

Steps to reproduce:

  1. got to the profile fragment ,
  2. click on the small camera image on the down right of profile pic circle,
  3. it will start the edit profile activity and show a botttomCardView for profile pic options.

Expected behavior:

That ImageView should not exist there if it's supposed to open Edit Profile activity, so it should be removed.

Observed behavior:

Right now that ImageView exists there and makes no sense because we already have edit profile activity.

Device and Android version:

VIVO Y83, Android version = 8.1.1

Screenshots:

@kartikeytyagi15
Copy link

@EGOR-IND please review PR
Thanks.

@EGOR-IND
Copy link
Contributor Author

Hey @kartikeytyagi15 are you new to this community because you should ask first before working on any issue because I was working on this issue too, so ask first and I admit that I didn't posted a comment saying "I'm working on it", it's my fault too but please always ask first it resolves the conflicts.

@EGOR-IND
Copy link
Contributor Author

And i'll review your PR in some minutes so don't it'll get reviewed😊

@kartikeytyagi15
Copy link

oh sorry, no one was assigned to this issue so I assumed its open for all, will keep that in mind.

@EGOR-IND
Copy link
Contributor Author

actually @kartikeytyagi15 the assigning permissions are not given to everyone only the verified contributors have those permissions, so always ask first:).

@kartikeytyagi15
Copy link

okay

@TanishMoral11
Copy link

hey @EGOR-IND , I’d like to work on this issue. Could you assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants